Skip to content

Conversation

@jfegg
Copy link
Contributor

@jfegg jfegg commented Nov 20, 2025

Added a test case with mixed dtypes in a DataFrame and checks dtypes after DataFrame.update

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Can you also add a parameter for Int64 in test_update_preserve_dtype as mentioned here: #44104 (comment)

@jfegg
Copy link
Contributor Author

jfegg commented Nov 20, 2025

I added an Int64 parameter to test_update_preserve_dtype. Let me know if there were any other changes you were looking for!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added Dtype Conversions Unexpected or buggy dtype conversions Needs Tests Unit test(s) needed to prevent regressions combine/combine_first/update NDFrame.combine, combine_first, update labels Nov 20, 2025
@rhshadrach rhshadrach added this to the 3.0 milestone Nov 20, 2025
@rhshadrach rhshadrach merged commit 9c58220 into pandas-dev:main Nov 23, 2025
55 of 56 checks passed
@rhshadrach
Copy link
Member

Thanks @jfegg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

combine/combine_first/update NDFrame.combine, combine_first, update Dtype Conversions Unexpected or buggy dtype conversions Needs Tests Unit test(s) needed to prevent regressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: DataFrame.update do not preserve string dtype

2 participants